-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up unused and extraneous code #181
Conversation
🦋 Changeset detectedLatest commit: b315140 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report ✅ No errors or warnings @tbdex/protocol
@tbdex/http-client
@tbdex/http-server
TBDocs Report Updated at 2024-02-27T14:26:29Z |
aa846ad
to
c138dac
Compare
c138dac
to
f1025c1
Compare
Changeset notes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is excellent!
(I kinda think we may be able to axe the dev tools altogether, but maintain the dummy data for test purposes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this
I'd be down. The only reason we're exporting devtools from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
this addresses #178
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 92.64% 93.07% +0.43%
==========================================
Files 37 37
Lines 3059 2990 -69
Branches 329 323 -6
==========================================
- Hits 2834 2783 -51
+ Misses 225 207 -18
|
DevTools.createDid()
and replace withDidDht.create()
orDidJwt.create()
. Based on rule of thumb that we should only use DevTools if the alternative is significantly more verbose.packages/protocol/src/did-resolver.ts
andpackages/protocol/src/crypto.ts