Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused and extraneous code #181

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Clean up unused and extraneous code #181

merged 7 commits into from
Feb 27, 2024

Conversation

diehuxx
Copy link
Contributor

@diehuxx diehuxx commented Feb 21, 2024

  • Remove DevTools.createDid() and replace with DidDht.create() or DidJwt.create(). Based on rule of thumb that we should only use DevTools if the alternative is significantly more verbose.
  • Remove dead code and update comments in packages/protocol/src/did-resolver.ts and packages/protocol/src/crypto.ts

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: b315140

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@tbdex/http-server Minor
@tbdex/protocol Minor
@tbdex/http-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 21, 2024

TBDocs Report

✅ No errors or warnings

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts

TBDocs Report Updated at 2024-02-27T14:26:29Z b315140

@KendallWeihe
Copy link
Contributor

Changeset notes?

Copy link
Contributor

@KendallWeihe KendallWeihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is excellent!

(I kinda think we may be able to axe the dev tools altogether, but maintain the dummy data for test purposes)

Copy link
Member

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this

@diehuxx
Copy link
Contributor Author

diehuxx commented Feb 22, 2024

(I kinda think we may be able to axe the dev tools altogether, but maintain the dummy data for test purposes)

I'd be down. The only reason we're exporting devtools from tbdex/protocol is we're using those same fixtures in the http packages. The easiest alternative is to copypaste the test fixtures into all three packages and don't export the fixtures from any of them. I can cover that in a follow up PR.

Copy link
Contributor

@kirahsapong kirahsapong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

this addresses #178

@jiyoontbd jiyoontbd linked an issue Feb 26, 2024 that may be closed by this pull request
* main:
  upgrade to ip patch (#186)
  During request token verification, check that JWTHeader.kid includes the same DID as JWTClaims.iss (#176)
  update vector generation script to use `did:dht` dids for pfi and alice (#185)
  add hermit (#183)
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #181 (b315140) into main (9a8c930) will increase coverage by 0.43%.
Report is 1 commits behind head on main.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   92.64%   93.07%   +0.43%     
==========================================
  Files          37       37              
  Lines        3059     2990      -69     
  Branches      329      323       -6     
==========================================
- Hits         2834     2783      -51     
+ Misses        225      207      -18     
Components Coverage Δ
protocol 94.27% <80.00%> (+0.81%) ⬆️
http-client 94.14% <ø> (ø)
http-server 89.49% <ø> (ø)

@diehuxx diehuxx merged commit 4f45153 into main Feb 27, 2024
16 of 17 checks passed
@diehuxx diehuxx deleted the web5-update-follow-ups branch February 27, 2024 23:52
This was referenced Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide whether to continue supporting DevTools utility functions
4 participants