Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add balance resource and todos #212

Merged
merged 15 commits into from
Mar 29, 2024
Merged

Add balance resource and todos #212

merged 15 commits into from
Mar 29, 2024

Conversation

kirahsapong
Copy link
Contributor

@kirahsapong kirahsapong commented Mar 25, 2024 •
edited
Loading

closes #138

  • adds Balance resource and protocol tests
  • adds client getBalance method and tests
  • adds server GET /balance endpoint, handlers and tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7716e0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024 •
edited
Loading

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 3

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts
📄 File: packages/http-server/src/http-server.ts
⚠️ extractor:ae-unresolved-link: The @link reference could not be resolved: The package "@tbdex/http-server" does not have an export "InMemoryOfferingsApi" #L49
⚠️ extractor:ae-unresolved-link: The @link reference could not be resolved: The package "@tbdex/http-server" does not have an export "InMemoryExchangesApi" #L49
⚠️ extractor:ae-unresolved-link: The @link reference could not be resolved: The package "@tbdex/http-server" does not have an export "InMemoryBalancesApi" #L49

TBDocs Report Updated at 2024-03-29T15:50:25Z 7716e0a

@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #212 (77954d8) into main (529b37a) will decrease coverage by 1.76%.
The diff coverage is 35.71%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   93.53%   91.77%   -1.76%     
==========================================
  Files          39       40       +1     
  Lines        3141     3236      +95     
  Branches      356      357       +1     
==========================================
+ Hits         2938     2970      +32     
- Misses        203      266      +63
Components Coverage Δ
protocol 91.06% <35.71%> (-3.22%) ⬇️
http-client 94.83% <ø> (ø)
http-server 91.05% <ø> (ø)

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024 •
edited
Loading

Codecov Report

Merging #212 (818ce7a) into main (6dea4d9) will increase coverage by 0.11%.
The diff coverage is 94.46%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   92.91%   93.03%   +0.11%     
==========================================
  Files          39       42       +3     
  Lines        3104     3386     +282     
  Branches      344      374      +30     
==========================================
+ Hits         2884     3150     +266     
- Misses        220      236      +16
Components Coverage Δ
protocol 93.32% <95.37%> (+0.10%) ⬆️
http-client 95.27% <100.00%> (+0.34%) ⬆️
http-server 90.87% <91.91%> (+0.16%) ⬆️

@kirahsapong kirahsapong marked this pull request as ready for review March 28, 2024 19:24
@kirahsapong kirahsapong mentioned this pull request Mar 28, 2024
Merged
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 28, 2024
View reviewed changes
packages/http-server/tests/get-balances.spec.ts Dismissed Show dismissed Hide dismissed
packages/http-server/tests/get-balances.spec.ts Dismissed Show dismissed Hide dismissed
packages/http-server/src/http-server.ts Dismissed Show dismissed Hide dismissed
KendallWeihe
KendallWeihe approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@KendallWeihe KendallWeihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two open comments but neither are blockers

awesome work here!

packages/protocol/src/types.ts Outdated Show resolved Hide resolved
packages/http-server/src/http-server.ts Outdated Show resolved Hide resolved
jiyoontbd
jiyoontbd reviewed Mar 29, 2024
View reviewed changes
tbdex Outdated Show resolved Hide resolved
@jiyoontbd jiyoontbd mentioned this pull request Mar 29, 2024
Merged
@kirahsapong kirahsapong merged commit 7edf704 into main Mar 29, 2024
8 checks passed
@kirahsapong kirahsapong deleted the feat/add-balance-resource branch March 29, 2024 16:00
diehuxx added a commit that referenced this pull request Mar 30, 2024
@diehuxx
Merge branch 'main' into rfq-private-salt
a27afd2 
* main:
  Refresh offerings test vector (#218)
  updating parse close vector with success field (#220)
  Add balance resource and todos (#212)
@kirahsapong kirahsapong mentioned this pull request Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KendallWeihe KendallWeihe KendallWeihe approved these changes

@jiyoontbd jiyoontbd jiyoontbd approved these changes

@diehuxx diehuxx diehuxx approved these changes

@michaelneale michaelneale Awaiting requested review from michaelneale michaelneale is a code owner

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement GET account balance endpoint and client method
5 participants
@kirahsapong @codecov-commenter @KendallWeihe @diehuxx @jiyoontbd