Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Close.success #219

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Add Close.success #219

merged 3 commits into from
Mar 28, 2024

Conversation

diehuxx
Copy link
Contributor

@diehuxx diehuxx commented Mar 28, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 56f9228

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

TBDocs Report

✅ No errors or warnings

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts

TBDocs Report Updated at 2024-03-28T23:47:11Z 56f9228

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024 •
edited
Loading

Codecov Report

Merging #219 (dd6f589) into main (6dea4d9) will not change coverage.
The diff coverage is n/a.

❗ Current head dd6f589 differs from pull request most recent head 56f9228. Consider uploading reports for the commit 56f9228 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          39       39           
  Lines        3104     3104           
  Branches      344      344           
=======================================
  Hits         2884     2884           
  Misses        220      220
Components Coverage Δ
protocol 93.21% <ø> (ø)
http-client 94.92% <ø> (ø)
http-server 90.71% <ø> (ø)

kirahsapong
kirahsapong approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@kirahsapong kirahsapong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test that close is created with success would be good. not a blocker.

angiejones
angiejones reviewed Mar 28, 2024
View reviewed changes
packages/protocol/src/types.ts Outdated
@@ -342,5 +342,6 @@ export type OrderStatusData = {
export type CloseData = {
/** an explanation of why the exchange is being closed */
reason?: string
/** indicates whether or not the exchange successfully completed */
success?: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be boolean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @angiejones

@diehuxx diehuxx merged commit fa95997 into main Mar 28, 2024
8 checks passed
@diehuxx diehuxx deleted the close-success branch March 28, 2024 23:47
diehuxx added a commit that referenced this pull request Mar 29, 2024
@diehuxx
Merge branch 'main' into rfq-private-salt
aa08adb 
* main:
  Add Close.success (#219)
  Rip out List Offering query params (#217)
  Add OSP Reusable Workflow for Scans (#214)
@KendallWeihe
Copy link
Contributor

@diehuxx I think we also need to update the message-kinds/order.ts in the protocol package to allow close messages after an order message, right?

readonly validNext = new Set<MessageKind>(['orderstatus'])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angiejones angiejones angiejones left review comments

@kirahsapong kirahsapong kirahsapong approved these changes

@wesbillman wesbillman wesbillman approved these changes

@jiyoontbd jiyoontbd jiyoontbd approved these changes

@michaelneale michaelneale Awaiting requested review from michaelneale michaelneale is a code owner

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew

@KendallWeihe KendallWeihe Awaiting requested review from KendallWeihe KendallWeihe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@diehuxx @codecov-commenter @KendallWeihe @wesbillman @angiejones @kirahsapong @jiyoontbd