-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boosted http-client code coverage to 100% + minor updates #234
Conversation
|
TBDocs Report 🛑 Errors: 0 @tbdex/protocol
@tbdex/http-client
@tbdex/http-server
TBDocs Report Updated at 2024-04-05T04:06:17Z |
const bob = await DidJwk.create() | ||
const bobRfq = await DevTools.createRfq({ sender: bob }) | ||
await bobRfq.sign(bob) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe what would make more sense naming wise is to say aliceRfq1
and aliceRfq2
, since the GET /exchanges call would be returning all exchanges for a given did? so maybe something like
const bob = await DidJwk.create() | |
const bobRfq = await DevTools.createRfq({ sender: bob }) | |
await bobRfq.sign(bob) | |
const aliceRfq2 = await DevTools.createRfq({ sender: alice }) | |
await aliceRfq2.sign(alice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks @jiyoontbd for the knowledge, makes sense, didn't realize the did
property was meant to be for the caller, I've updated that too, let me know if I misunderstood again!
const aliceRfq = await DevTools.createRfq({ sender: alice }) | ||
await aliceRfq.sign(alice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const aliceRfq = await DevTools.createRfq({ sender: alice }) | |
await aliceRfq.sign(alice) | |
const aliceRfq1 = await DevTools.createRfq({ sender: alice }) | |
await aliceRfq1.sign(alice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 93.92% 94.77% +0.84%
==========================================
Files 42 42
Lines 3590 3541 -49
Branches 402 390 -12
==========================================
- Hits 3372 3356 -16
+ Misses 218 185 -33
|
http-client
to have 100% code coveragesetPrototypeOf()
html
reporter for code coverage for local detailed report