Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed query params for List Exchanges API #244

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

thehenrytsai
Copy link
Member

Follow up for TBD54566975/tbdex#312 to remove the query params.

Will also update the API implementation to return just the IDs as per #239 in a follow up PR.

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 1b2078a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@tbdex/http-server Minor
@tbdex/protocol Minor
@tbdex/http-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 19, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 3

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts
📄 File: packages/http-server/src/http-server.ts
⚠️ extractor:ae-unresolved-link: The @link reference could not be resolved: The package "@tbdex/http-server" does not have an export "InMemoryOfferingsApi" #L49
⚠️ extractor:ae-unresolved-link: The @link reference could not be resolved: The package "@tbdex/http-server" does not have an export "InMemoryExchangesApi" #L49
⚠️ extractor:ae-unresolved-link: The @link reference could not be resolved: The package "@tbdex/http-server" does not have an export "InMemoryBalancesApi" #L49

TBDocs Report Updated at 2024-04-19T19:33:59Z 1b2078a

@codecov-commenter
Copy link

Codecov Report

Merging #244 (1b2078a) into main (8d8f022) will increase coverage by 12.21%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #244       +/-   ##
===========================================
+ Coverage   83.50%   95.71%   +12.21%     
===========================================
  Files          42       42               
  Lines        3547     3528       -19     
  Branches      289      387       +98     
===========================================
+ Hits         2962     3377      +415     
+ Misses        585      151      -434     
Components Coverage Δ
protocol 94.90% <ø> (ø)
http-client 100.00% <ø> (ø)
http-server 94.65% <100.00%> (+46.25%) ⬆️

@thehenrytsai thehenrytsai changed the title Removed query params for List Exchange API Removed query params for List Exchanges API Apr 19, 2024
@thehenrytsai thehenrytsai merged commit c7da892 into main Apr 23, 2024
8 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/remove-query-params-for-list-exchanges branch April 23, 2024 16:56
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants