Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code and tests to align with latest tbdex main #261

Merged
merged 11 commits into from
Jul 19, 2024

Conversation

thehenrytsai
Copy link
Member

@thehenrytsai thehenrytsai commented Jul 18, 2024

  1. Updated tbdex submodule reference.
  2. Updated code and tests to reflect Offering spec changes.
  3. Updated code and tests to reflect RFQ spec changes.
  4. Updated code and tests to reflect Quote spec changes.
  5. Updated code and tests to reflect Order Status spec changes.
  6. Fixed instructions for updating tbdex submodule in README.
  7. Fixed tbDoc warnings.

Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: f783526

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@tbdex/protocol Major
@tbdex/http-server Major
@tbdex/http-client Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 18, 2024

TBDocs Report

✅ No errors or warnings

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts

TBDocs Report Updated at 2024-07-18T19:43:49Z f783526

@thehenrytsai thehenrytsai marked this pull request as draft July 18, 2024 18:50
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (8f07e7e) to head (f783526).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   95.71%   95.78%   +0.06%     
==========================================
  Files          42       42              
  Lines        3528     3533       +5     
  Branches      387      387              
==========================================
+ Hits         3377     3384       +7     
+ Misses        151      149       -2     
Components Coverage Δ
protocol 95.01% <100.00%> (+0.11%) ⬆️
http-client 100.00% <ø> (ø)
http-server 94.65% <100.00%> (ø)

@thehenrytsai thehenrytsai marked this pull request as ready for review July 18, 2024 19:39
@thehenrytsai thehenrytsai changed the title Updated code and tests to align with latest tbDEX spec Updated code and tests to align with latest tbdex main Jul 18, 2024
Copy link
Contributor

@jiyoontbd jiyoontbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot!

@michaelneale
Copy link
Contributor

nice one @thehenrytsai - any chance you could cast eyes over https://github.com/TBD54566975/tbdex-pfi-exemplar and https://github.com/TBD54566975/tbd-examples/tree/main/javascript/pfi-aud-usd-tbdex some time for any migration we may need to do?

@thehenrytsai
Copy link
Member Author

@michaelneale, for sure! Will take a look next week after a bunch PRs currently waiting on me!

@thehenrytsai
Copy link
Member Author

Thanks @jiyoontbd for reviewing (and keeping the spec + schema up-to-date in tbdex repo, making these changes a smooth sail!).

@thehenrytsai thehenrytsai merged commit fa3dfe8 into main Jul 19, 2024
15 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/tbdex-update-2024-07-18 branch July 19, 2024 16:00
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants