Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Modify sample to use did:dht instead of did:ion #22

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Conversation

kirahsapong
Copy link
Contributor

closes #6

@kirahsapong kirahsapong marked this pull request as ready for review February 6, 2024 22:35
@@ -39,11 +39,11 @@ export const config: Config = {
// a new one will be generated every time the process starts.
if (!config.did) {
console.log('Creating an ephemeral DID.....')
const DidIon = await DidIonMethod.create({
const DidDht = await DidDhtMethod.create({ publish: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will publish by default, so no need for publish: true, unless you want to make it explicit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting the same error mentioned here without passing publish: true - currently on 0.2.4 (same as tbdex) sounds like that is removed in future versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed! 0.2.4 defaults to false, later versions default to true. will need to update tbdex before we can update here!

@@ -5,7 +5,7 @@ import fs from 'node:fs'

import 'dotenv/config'

import { DidIonMethod, PortableDid } from '@web5/dids'
import { PortableDid, DidDhtMethod } from '@web5/dids'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change soon, but good stuff for now 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice! yee once tbdex updates will update here tew

@michaelneale
Copy link
Contributor

michaelneale commented Feb 6, 2024

nice - could the example scripts also be converted to use it? should they?

ie does https://github.com/TBD54566975/tbdex-pfi-exemplar/blob/main/src/example/utils.ts - automatically use diddht?

@kirahsapong
Copy link
Contributor Author

nice - could the example scripts also be converted to use it? should they?

@michaelneale done!

@kirahsapong kirahsapong merged commit 976967b into main Feb 7, 2024
3 checks passed
@kirahsapong kirahsapong deleted the feat/did-dht branch February 7, 2024 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modify the sample to use did:dht instead of did:ion
4 participants