Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran generate-test-vectors in tbdex-js PR #152 to update test vectors #229

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

jiyoontbd
Copy link
Contributor

No description provided.

@jiyoontbd jiyoontbd marked this pull request as ready for review January 24, 2024 21:47
Copy link
Contributor

@diehuxx diehuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these vectors being updated? What is the purpose of the change?

@jiyoontbd
Copy link
Contributor Author

Why are these vectors being updated? What is the purpose of the change?

These vectors were updated due to generate-test-vectors file being updated in this pr - the PR changes included overwriting the files in the tbdex submodule, and also included adding of new generate methods for close, order, and orderstatus. i ran pnpm generate-test-vector in the tbdex-js/packages/protocol directory, which overwrote these files and i created a PR for these changes.

@kirahsapong
Copy link
Contributor

@diehuxx of note there were also errors in the previous test vectors which were leading to failing tests, @jiyoontbd's updates resolve those 👍

@diehuxx
Copy link
Contributor

diehuxx commented Jan 25, 2024

@diehuxx of note there were also errors in the previous test vectors which were leading to failing tests, @jiyoontbd's updates resolve those 👍

@kirahsapong @jiyoontbd
Were you able to tell what the errors in the previous tests were?

@mistermoe
Copy link
Member

@diehuxx yep the signatures in the vectors on main are incorrect due to a bug that we fixed in the work @kirahsapong @jiyoontbd and i have done

@jiyoontbd jiyoontbd merged commit e298dc2 into main Jan 25, 2024
@jiyoontbd jiyoontbd deleted the test-vector-changes branch January 25, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants