Require salt in Rfq privateData JSON schema #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
michaelneale,
mistermoe,
jiyoontbd,
phoebe-lew,
KendallWeihe,
kirahsapong and
decentralgabe
as code owners
|
Should 
|
KendallWeihe
approved these changes
Mar 31, 2024
jiyoontbd
approved these changes
Mar 31, 2024
kirahsapong
approved these changes
Mar 31, 2024
| | field | data type | required | description | | ||
| | -------- | ------------------------------------------------- | -------- | ------------------------------------------------------------------------------------- | | ||
| | `salt` | string | N | | | ||
| | `salt` | string | Y | Randomly generated salt used for hashing PrivateData fields | |
There was a problem hiding this comment.
nice. the rfq json example below this table will need updating too
There was a problem hiding this comment.
this example too actually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KendallWeihe pointed out that we should make
salta required field inRfq.privateDatabecause theprivateDatais impossible to validate -- and therefore useless -- without the salt.TODO: validate in at least two implementations: