Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase default sync interval from 1s -> 2m #144

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

mistermoe
Copy link
Member

@mistermoe mistermoe commented Jul 5, 2023

Per @mistermoe, as reported on Discord:

If you leave the network tab open for long enough in safari or chrome
The tab crashes
Bc of the polling

2 minute interval was based on discussion on Discord but could be revisited based on new information in the future.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #144 (3f8b974) into main (b9f7f98) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   64.74%   64.76%   +0.01%     
==========================================
  Files          33       33              
  Lines        3551     3553       +2     
  Branches      198      198              
==========================================
+ Hits         2299     2301       +2     
  Misses       1250     1250              
  Partials        2        2              
Components Coverage Δ
common 0.00% <ø> (ø)
credentials 0.00% <ø> (ø)
crypto 0.00% <ø> (ø)
dids 48.61% <ø> (ø)
web5 81.54% <66.66%> (+0.02%) ⬆️
web5-agent 0.00% <ø> (ø)
web5-proxy-agent 0.00% <ø> (ø)
web5-user-agent 79.60% <ø> (ø)

Copy link
Contributor

@frankhinek frankhinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistermoe mistermoe merged commit 383797f into main Jul 6, 2023
20 of 21 checks passed
@frankhinek frankhinek deleted the sync-interval branch July 6, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants