Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding required property 'published' to protocols.configure example #218

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

angiejones
Copy link
Member

without the published property on a protocol definition, the following error occurs:

Error: /descriptor/definition: must have required property 'published'

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #218 (19579f3) into main (7ff1747) will not change coverage.
Report is 19 commits behind head on main.
The diff coverage is n/a.

❗ Current head 19579f3 differs from pull request most recent head 610d93b. Consider uploading reports for the commit 610d93b to get more accurate results

@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          67       67           
  Lines       12828    12828           
  Branches     1238     1238           
=======================================
  Hits        11486    11486           
  Misses       1319     1319           
  Partials       23       23           
Components Coverage Δ
api 94.32% <ø> (ø)
common 95.00% <ø> (ø)
credentials 92.77% <ø> (ø)
crypto 94.87% <ø> (ø)
dids 92.16% <ø> (ø)
agent 87.80% <ø> (ø)
identity-agent 59.05% <ø> (ø)
proxy-agent 58.59% <ø> (ø)
user-agent 57.36% <ø> (ø)

Copy link
Contributor

@frankhinek frankhinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added change to the packages/api/README.md to keep the files in sync but otherwise LGTM

@frankhinek frankhinek merged commit d442b66 into TBD54566975:main Nov 3, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants