Remove old package #236
Merged
Remove old package #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amika-sq
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 90.99% 90.97% -0.03%
==========================================
Files 67 67
Lines 12645 12648 +3
Branches 1261 1261
==========================================
Hits 11506 11506
- Misses 1116 1119 +3
Partials 23 23
|
|
@amika-sq have been wanting to do this for a while its only there out of convenience, and I've got The last thing I'm pulling out old that needs to go back into the new packages is the Connect Protocol code (original implementation was from 6+ months ago, pre polyrepo). but safe to remove since we can always pull it from an earlier point in the commit history |
* main: Did ion: Set assertion method (TBD54566975#245) Update README to reflect dwn-sdk-js 0.2.3 (TBD54566975#237) changed the typo (TBD54566975#234) Upgrade to dwn sdk js v0.2.3 (TBD54566975#225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/oldclutters up searching through the monorepo. Wondering if we can get rid of it, now thatoldis ~2 months old at this point.