Secp256k1 - disable malleability check when verifying
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Codecov Report
@@ Coverage Diff @@
## main #244 +/- ##
==========================================
- Coverage 90.99% 90.97% -0.03%
==========================================
Files 67 67
Lines 12645 12648 +3
Branches 1260 1260
==========================================
Hits 11506 11506
- Misses 1116 1119 +3
Partials 23 23
|
|
@frankhinek can i get a stamp here? |
diehuxx
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant context here: TBD54566975/web5-kt#87
the best course of action may be to provide callers with the option to enable/disable the malleability check. Just didn't have the time to plumb this optionality down through the crypto algorithms interface. Wanted to get this PR out so that Verifiable Credential signature verification doesn't 💩 out for creds signed in environments that don't guarantee a
low-ssignature.cc: @andresuribe87