fix tsconfig errors #306
Merged
fix tsconfig errors #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilovtim
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
TBDocs Report ✅ No errors or warnings @web5/api
Updated @ 2023-11-24T05:42:46.572Z - Commit: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 73 73
Lines 15764 15765 +1
Branches 1448 1448
=======================================
+ Hits 14468 14469 +1
Misses 1270 1270
Partials 26 26
|
|
Unblocks #305 which has the strange tsc errors this fixes |
mistermoe
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
This looks good to me! it might be worth checking to make sure that the vscode workspace still works as expected. @frankhinek want to take a look at that?
|
@mistermoe looks like it works. tested auto import and a run command: Screen.Recording.2023-11-24.at.12.33.40.AM.mov |
|
nice! |
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
force-pushed
the
tshamilov/cleanup-tsconfigs-pt1
branch
from
e2f03e3
to
eae1b93
Compare
finn-tbd
pushed a commit
that referenced
this pull request
Mar 19, 2024
* cleanup tsc settings * add base tsconfig to DRY up tsconfigs. build sourcemaps for all. * DRY up remaining repeated fields * strict false for web5spec * Minor fix to remove trailing commas from JSON --------- Co-authored-by: Frank Hinek <[email protected]>
finn-tbd
pushed a commit
that referenced
this pull request
Mar 19, 2024
* cleanup tsc settings * add base tsconfig to DRY up tsconfigs. build sourcemaps for all. * DRY up remaining repeated fields * strict false for web5spec * Minor fix to remove trailing commas from JSON --------- Co-authored-by: Frank Hinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR
Solution
outDiranddeclarationDir)