Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple tbdocs commenter #323

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

leordev
Copy link
Member

@leordev leordev commented Nov 29, 2023

Now we also have the tbdocs report in the GH Action summary!
image

https://github.com/TBD54566975/web5-js/actions/runs/7039346479?pr=323#summary-19158131202

PS: the tbdocs report comment in the PR will only start to show up when we merge this PR to main. Unfortunately this is the normal behavior for new workflow_run definitions.

Working evidence:

Copy link

codesandbox bot commented Nov 29, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #323 (b8d5c4f) into main (dce370d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files          73       73           
  Lines       15764    15764           
  Branches     1448     1448           
=======================================
  Hits        14468    14468           
  Misses       1270     1270           
  Partials       26       26           
Components Coverage Δ
api 96.69% <ø> (ø)
common 95.00% <ø> (ø)
credentials 94.32% <ø> (ø)
crypto 100.00% <ø> (ø)
dids 88.75% <ø> (ø)
agent 88.08% <ø> (ø)
identity-agent 56.81% <ø> (ø)
proxy-agent 58.43% <ø> (ø)
user-agent 55.22% <ø> (ø)

@leordev leordev marked this pull request as ready for review November 29, 2023 23:13
Copy link
Member

@shamilovtim shamilovtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this run on push only rather than on every commit of every PR?

on:
  push:
    branches:
      - main

.github/workflows/docs-ci.yml Show resolved Hide resolved
Copy link
Contributor

@frankhinek frankhinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught up with @leordev about getting the next step done after this which is to publish the API docs to gh-pages. Hope to get that prioritized for next week.

@leordev leordev merged commit a23b49a into main Nov 30, 2023
29 of 30 checks passed
@leordev leordev deleted the leordev/issue-319.decouple-security branch November 30, 2023 20:05
finn-tbd pushed a commit that referenced this pull request Mar 19, 2024
* decouple tbdocs commenter

* trigger comment

* Decouple docs actions
finn-tbd pushed a commit that referenced this pull request Mar 19, 2024
* decouple tbdocs commenter

* trigger comment

* Decouple docs actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants