Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DID:DHT implementation to be compliant with vector 1 #504

Merged
merged 7 commits into from
May 2, 2024

Conversation

thehenrytsai
Copy link
Member

@thehenrytsai thehenrytsai commented May 1, 2024

  1. Updated DID:DHT implementation to be compliant with vector 1
  2. Added self to default owners in CODEOWNERS
  3. Opportunistic QoL update: excluded generated files from search results
  4. Opportunistic QoL update:: allow one click debugging for DID project

Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 7272955

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web5/dids Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 1, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 7

@web5/api

  • Project entry file: packages/api/src/index.ts
📄 File: ./packages/api/src/record.ts
⚠️ extractor:typedoc:missing-docs: Record.tags (GetSignature) does not have any documentation.

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts
📄 File: ./packages/crypto-aws-kms/src/ecdsa.ts
⚠️ extractor:typedoc:missing-docs: EcdsaAlgorithm (Class) does not have any documentation.
📄 File: ./packages/crypto-aws-kms/src/key-manager.ts
⚠️ extractor:typedoc:missing-docs: AwsKeyManager (Class) does not have any documentation.
📄 File: ./packages/crypto-aws-kms/src/utils.ts
⚠️ extractor:typedoc:missing-docs: getKeySpec (CallSignature) does not have any documentation.
🔀 Misc.
⚠️ extractor:typedoc:invalid-link: Failed to resolve link to "@web5/crypto#Secp256k1.adjustSignatureToLowS | here" in comment for EcdsaAlgorithm.sign. You may have wanted "@web5/crypto!Secp256k1.adjustSignatureToLowS | here"

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts
📄 File: ./packages/credentials/src/verifiable-credential.ts
⚠️ extractor:typedoc:missing-docs: CredentialSchema.__type.id (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CredentialSchema.__type.type (Property) does not have any documentation.

TBDocs Report Updated at 2024-05-01T20:34:13Z 7272955

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (393d483) to head (7272955).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   90.56%   90.81%   +0.24%     
==========================================
  Files         112      116       +4     
  Lines       29117    29414     +297     
  Branches     2085     2156      +71     
==========================================
+ Hits        26370    26711     +341     
+ Misses       2712     2668      -44     
  Partials       35       35              
Components Coverage Δ
agent 79.90% <ø> (+1.07%) ⬆️
api 97.91% <ø> (ø)
common 98.68% <ø> (ø)
credentials 95.25% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.66% <100.00%> (+<0.01%) ⬆️
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

nitro-neal
nitro-neal previously approved these changes May 1, 2024
Copy link
Contributor

@diehuxx diehuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! +1 to @nitro-neal's comment, I would love to see the new test vectors added to the web5-spec

@thehenrytsai thehenrytsai merged commit 857d160 into main May 2, 2024
10 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/dids-vector-1 branch May 2, 2024 07:53
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants