Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use workspace for deps #903

Merged
merged 2 commits into from
Sep 19, 2024
Merged

use workspace for deps #903

merged 2 commits into from
Sep 19, 2024

Conversation

shamilovtim
Copy link
Member

@shamilovtim shamilovtim commented Sep 16, 2024

Context

When debugging an issue last week we found the @web5/common package was duplicated multiple times in the monorepo by shipping 3 different versions to the other packages, which was both unexpected and made debugging more difficult

Implementation

Use the workspace pnpm directive in order to link the local packages rather than the published packages. This links the packages to the same local version and removes the strain of having to manually manage it.

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 0ae5162

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@web5/crypto-aws-kms Patch
@web5/identity-agent Patch
@web5/credentials Patch
@web5/proxy-agent Patch
@web5/user-agent Patch
@web5/crypto Patch
@web5/agent Patch
@web5/dids Patch
@web5/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 16, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 5

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts
📄 File: ./packages/crypto/src/utils.ts
⚠️ extractor:typedoc:missing-docs: CryptoUtils (Variable) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomPin (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomUuid (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomBytes (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.getJoseSignatureAlgorithmFromPublicKey (Property) does not have any documentation.

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-09-16T12:57:05Z 0ae5162

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.44%. Comparing base (b97dace) to head (0ae5162).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files         117      117           
  Lines       33470    33470           
  Branches     2704     2704           
=======================================
  Hits        31277    31277           
  Misses       2154     2154           
  Partials       39       39           
Components Coverage Δ
agent 87.44% <ø> (ø)
api 99.61% <ø> (ø)
common 98.68% <ø> (ø)
credentials 94.95% <ø> (ø)
crypto 93.79% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.42% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.42% <ø> (ø)
user-agent 96.57% <ø> (ø)

@shamilovtim shamilovtim merged commit 17a4290 into main Sep 19, 2024
35 checks passed
@shamilovtim shamilovtim deleted the tshamilov/pnpm-workspace branch September 19, 2024 16:47
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants