-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Connect Auth Response #951
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: afc0c2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-10-11T20:35:03Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 118 118
Lines 33660 33665 +5
Branches 2728 2728
=======================================
+ Hits 31419 31424 +5
- Misses 2200 2201 +1
+ Partials 41 40 -1
|
3b9e435
to
afc0c2a
Compare
This PR pulls the portion from
submitAuthResponse
that creates the authorization grants out into it's own functioncreateAuthResponseGrants
.Additionally, the creation of the JWK is pulled out of the
submitAuthResponse
method. So a response for the OIDC flow now looks like this:There is further optimization that could be done as well as the clean-up of failed grant authorizations, but I will leave that for after the extended OIDC flow is merged in to avoid too much change.