Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsjava version bump #337

Merged
merged 2 commits into from
Aug 13, 2024
Merged

dnsjava version bump #337

merged 2 commits into from
Aug 13, 2024

Conversation

jiyoontbd
Copy link
Contributor

@jiyoontbd jiyoontbd commented Aug 13, 2024

Overview

bump dnsjava to 3.6.0

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (3f4ba2b) to head (f3fb5c3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files          44       44           
  Lines        2096     2096           
  Branches      402      402           
=======================================
  Hits         1598     1598           
  Misses        304      304           
  Partials      194      194           
Components Coverage Δ
credentials 81.31% <ø> (ø)
crypto 61.67% <ø> (ø)
dids 80.63% <ø> (ø)
common 65.21% <ø> (ø)

Copy link
Contributor

@KendallWeihe KendallWeihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making sure it was intentional @jiyoontbd you bumped the web5-spec submodule too fyi, I don't see any problem with it, but don't see it in the description so making sure you didn't do it by accident or if so that you're okay with it

@jiyoontbd jiyoontbd merged commit 8123612 into main Aug 13, 2024
10 checks passed
@jiyoontbd jiyoontbd deleted the bump-dnsjava branch August 13, 2024 20:43
@jiyoontbd
Copy link
Contributor Author

making sure it was intentional @jiyoontbd you bumped the web5-spec submodule too fyi, I don't see any problem with it, but don't see it in the description so making sure you didn't do it by accident or if so that you're okay with it

Yep. I bumped it to latest I could given that anything after that commit fails test due to a new select credential test vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants