Refactor jws #143 #162
Merged
Refactor jws #143 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
|
working on this to compliment this draft - #149 |
kirahsapong
approved these changes
May 6, 2024
crates/jws/src/lib.rs
Outdated
| @@ -27,6 +29,10 @@ pub enum JwsError { | |||
| AlgorithmNotFound(String), | |||
| #[error(transparent)] | |||
| CryptoError(#[from] CryptoError), | |||
| #[error("serde json error {0}")] | |||
There was a problem hiding this comment.
we are taking this whole beautiful lib and throwing it in the trash to make way for v2 after all v2s are ready for the big bang - so these changes dont mean anything eh?
There was a problem hiding this comment.
that's right! the 'ole "v2 this thing temporarily" strategy, which I can understand people not being receptive to, if not we can just hold off merging and string a sequence of PRs together, but I figure since it's a tight nit team working and we plan to do this within the next 2 days might as well keep our process time as low as possible
good catch, I removed these changes
nitro-neal
approved these changes
May 6, 2024
nitro-neal
approved these changes
May 6, 2024
|
moving fast and (not) breaking things (because we v2'd it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
jwsdeveloper surface in accordance with #143This PR creates the changes in a new
v2module, because there are downstream impacts to thejwtandcredentialscrates which will break those. The work for those crates is slated in #144 and #150; we will remove the old (non-v2 code) once that work is completed.This work is ready to be merged. Further work to be done related to this matter:
SerdeJsonErrorthroughout crates #165