Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add did web impl in web5-rs #273

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Add did web impl in web5-rs #273

merged 5 commits into from
Jul 31, 2024

Conversation

nitro-neal
Copy link
Contributor

@nitro-neal nitro-neal commented Jul 26, 2024 •
edited
Loading

Add did web impl to web5-rs

To test locally:

host a local did web here:
http://localhost:1234/.well-known/did.json

like this:

{
   "id":"did:web:www.tbd.website",
   "@context":[
      "https://www.w3.org/ns/did/v1"
   ],
   "verificationMethod":[
      {
         "id":"did:web:www.tbd.website#key-0",
         "type":"JsonWebKey",
         "controller":"did:web:www.tbd.website",
         "publicKeyJwk":{
            "alg":"Ed25519",
            "kty":"OKP",
            "crv":"Ed25519",
            "x":"gNFtgCZhOYv00p48FHQYt4edkoBPOyw0oGAB20LrT0c"
         }
      }
   ]
}

and rust and kt resolve correctly

@nitro-neal nitro-neal marked this pull request as ready for review July 30, 2024 20:35
@KendallWeihe
Copy link
Contributor

great work!

oh wait, I see we have some pipeline workflows failing @nitro-neal can you fix?

KendallWeihe
KendallWeihe reviewed Jul 31, 2024
View reviewed changes
bindings/web5_uniffi/libtargets/build_all.sh
@@ -0,0 +1,10 @@
#!/bin/bash

for dir in */; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@KendallWeihe KendallWeihe merged commit 5a79dc7 into main Jul 31, 2024
14 checks passed
@KendallWeihe KendallWeihe deleted the did-web-impl branch July 31, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KendallWeihe KendallWeihe KendallWeihe approved these changes

@kirahsapong kirahsapong Awaiting requested review from kirahsapong

@shamilovtim shamilovtim Awaiting requested review from shamilovtim shamilovtim is a code owner

@diehuxx diehuxx Awaiting requested review from diehuxx diehuxx is a code owner

@decentralgabe decentralgabe Awaiting requested review from decentralgabe

@frankhinek frankhinek Awaiting requested review from frankhinek frankhinek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitro-neal @KendallWeihe