Build byte code files in CI, remove from git tree #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
|
@leordev @ALRubinger I've added you as CODEOWNERS, lmk if you'd prefer to not be |
leordev
reviewed
Aug 12, 2024
leordev
approved these changes
Aug 12, 2024
nitro-neal
reviewed
Aug 13, 2024
.github/workflows/ci.yml
Outdated
| @@ -10,49 +22,193 @@ env: | |||
| CARGO_TERM_COLOR: always | |||
| # Make sure CI fails on all warnings, including Clippy lints | |||
| RUSTFLAGS: "-Dwarnings" | |||
| TBDEX_SDK_LOG_LEVEL: debug | |||
There was a problem hiding this comment.
TBDEX_SDK_LOG_LEVEL should be called WEB5_SDK_LOG_LEVEL here
There was a problem hiding this comment.
nice catch, fixed!
nitro-neal
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we have been checking-in the byte code files, but this is undesirable for many reasons. Most of the work here is a rip from TBD54566975/tbdex-rs#96
I've also removed the
jitpack.ymlbecause that will no longer function with the removal of the byte code files from source control.@ALRubinger @leordev I went as far as to run Maven tests, but could we go ahead and add snapshot deployments? I don't want to go the full 9-yards and add releases, but if we could go ahead and deploy snapshots then that would be a big win for cross-project integrations (since I'm removing the JitPack integration here).