Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web5 test vectors #284

Merged
merged 10 commits into from
Aug 16, 2024
Merged

Web5 test vectors #284

merged 10 commits into from
Aug 16, 2024

Conversation

nitro-neal
Copy link
Contributor

No description provided.

@nitro-neal
Copy link
Contributor Author

image

@nitro-neal nitro-neal marked this pull request as ready for review August 15, 2024 19:28
KendallWeihe
KendallWeihe reviewed Aug 15, 2024
View reviewed changes
crates/web5/src/dids/methods/did_dht/mod.rs Outdated

// As a replay attack protection protocol, if the same DID is doing a GET request within 5 minutes of each other, instead of a 404 it will start returning a 429.
// to get around this for our test we just create a new DID that is not published to get a fresh 404 for this error code
// if(vector_output.did_resolution_metadata.error == "notFound") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we can remove this line, yeah?

KendallWeihe
KendallWeihe approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@KendallWeihe KendallWeihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment on a line I think we can remove, but lgtm!

@KendallWeihe KendallWeihe merged commit 24966d2 into main Aug 16, 2024
15 checks passed
@KendallWeihe KendallWeihe deleted the web5-test-vectors branch August 16, 2024 15:00
@KendallWeihe KendallWeihe mentioned this pull request Aug 16, 2024
Merged
diehuxx added a commit that referenced this pull request Aug 17, 2024
@diehuxx
Merge branch 'main' into debug-logging
0654617 
* main:
  rfc3339, json, Web5Error, and VerifiableCredential  (#283)
  Web5 test vectors (#284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KendallWeihe KendallWeihe KendallWeihe approved these changes

@kirahsapong kirahsapong Awaiting requested review from kirahsapong

@shamilovtim shamilovtim Awaiting requested review from shamilovtim shamilovtim is a code owner

@diehuxx diehuxx Awaiting requested review from diehuxx diehuxx is a code owner

@decentralgabe decentralgabe Awaiting requested review from decentralgabe

@frankhinek frankhinek Awaiting requested review from frankhinek frankhinek is a code owner

@leordev leordev Awaiting requested review from leordev leordev is a code owner

@ALRubinger ALRubinger Awaiting requested review from ALRubinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitro-neal @KendallWeihe