Add feature complete Jwk #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe,
frankhinek,
leordev and
ALRubinger
as code owners
nitro-neal
reviewed
Aug 20, 2024
| import web5.sdk.rust.JwkData as RustCoreJwkData | ||
|
|
||
| /** | ||
| * Partial representation of a [JSON Web Key as per RFC7517](https://tools.ietf.org/html/rfc7517). | ||
| * Note that this is a subset of the spec. | ||
| */ | ||
| data class Jwk ( |
There was a problem hiding this comment.
by the way, why don't we have a kid field? we have them in the key for the test vectors - https://github.com/TBD54566975/web5-spec/blob/main/test-vectors/crypto_ed25519/sign.json
There was a problem hiding this comment.
Because we haven't have an immediate application use case for it
Created #297 feel free to add it!
nitro-neal
approved these changes
Aug 20, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToInner*andToOuter*for the kt key manager and signer (disintermediates the uniffi code gen)Web5Error:: DataMembererror variant -- signifies a semantic error for a given instances data members (ex. an empty string is a validStringtype in Rust but semantically invalid)