Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate X25519 keys #301

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Generate X25519 keys #301

merged 5 commits into from
Aug 21, 2024

Conversation

diehuxx
Copy link
Contributor

@diehuxx diehuxx commented Aug 21, 2024

Follow up from #299

@KendallWeihe
Copy link
Contributor

I guess since X25519 isn't a signature alg then it shouldn't be under the DSA namespace, yeah?

@KendallWeihe
Copy link
Contributor

we should remove X25519Signer and X25519Verifier from the APID too yeah?

@diehuxx
Copy link
Contributor Author

diehuxx commented Aug 21, 2024

Makes sense to me. Any preference on namespace?

@KendallWeihe
Copy link
Contributor

Any preference on namespace

It sounds like this is about key exchange, right? So idk maybe key_exchange? or else maybe just in the root crypto

@decentralgabe
Copy link
Member

key exchange is common terminology

@diehuxx diehuxx merged commit 93e0507 into main Aug 21, 2024
15 checks passed
@diehuxx diehuxx deleted the x25519-generator branch August 21, 2024 17:57
diehuxx added a commit that referenced this pull request Aug 21, 2024
@diehuxx
Merge branch 'main' into msrv-1.70.0
a6aef12 
* main:
  Use error for Verifier::verify(), Add ed25519 unit tests, Add Web5Error::Crypto (#300)
  Test Secp256k1Generator (#302)
  Generate X25519 keys (#301)
  Support X25519 in did:dht verification method (#299)
  add sign and verify test vectors (#292)
  Add feature complete Jwk (#294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KendallWeihe KendallWeihe KendallWeihe approved these changes

@nitro-neal nitro-neal Awaiting requested review from nitro-neal nitro-neal is a code owner

@kirahsapong kirahsapong Awaiting requested review from kirahsapong

@shamilovtim shamilovtim Awaiting requested review from shamilovtim shamilovtim is a code owner

@decentralgabe decentralgabe Awaiting requested review from decentralgabe

@frankhinek frankhinek Awaiting requested review from frankhinek frankhinek is a code owner

@leordev leordev Awaiting requested review from leordev leordev is a code owner

@ALRubinger ALRubinger Awaiting requested review from ALRubinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diehuxx @KendallWeihe @decentralgabe