Add full DidJwk & bind to kt #305
Conversation
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe,
frankhinek,
leordev and
ALRubinger
as code owners
| let did = match Did::parse(uri) { | ||
| Ok(d) => d, | ||
| Err(_) => return ResolutionResult::from_error(ResolutionMetadataError::InvalidDid), | ||
| }; | ||
|
|
||
| let decoded_jwk = match general_purpose::URL_SAFE_NO_PAD.decode(did.id) { | ||
| Ok(dj) => dj, | ||
| Err(_) => return ResolutionResult::from_error(ResolutionMetadataError::InvalidDid), | ||
| }; | ||
|
|
||
| let public_jwk = match serde_json::from_slice::<Jwk>(&decoded_jwk) { | ||
| Ok(pj) => pj, | ||
| Err(_) => return ResolutionResult::from_error(ResolutionMetadataError::InvalidDid), | ||
| }; |
There was a problem hiding this comment.
.map_err()? might be more concise than match statements here
There was a problem hiding this comment.
The return type is ResolutionResult, not Result. Might be a better option than I have right now tho
| STATIC METHOD create(options: DidJwkCreateOptions): BearerDid | ||
| STATIC METHOD resolve(uri: string): ResolutionResult |
There was a problem hiding this comment.
Is the intention to also change did:dht and did:dht to just have static create and remove constructors?
There was a problem hiding this comment.
yes, as well as did:web
| @@ -9,7 +9,7 @@ use super::{ | |||
| use crate::{ | |||
| crypto::{ | |||
| dsa::Signer, | |||
| key_managers::{in_memory_key_manager::InMemoryKeyManager, key_manager::KeyManager}, | |||
| key_managers::{in_memory_key_manager::InMemoryKeyManager, KeyManager}, | |||
There was a problem hiding this comment.
we can address export hierarchy/API in a separate PR, but mentioning just to put the idea out there: key_managers::in_memory_key_manager::InMemoryKeyManager is a lot of times to say "key manager" before I get to the thing I need. Luckily rust makes it easy to export things under the exact namespace we want while still keeping or underlying file hierarchy the same.
Some musings about namespaces in this talk about python may also apply in rust. Namely, namespaces are best for preventing collisions, and can become cumbersome when used to create taxonomies.
There was a problem hiding this comment.
I 100% agree and it would be awesome if you want to spearhead @diehuxx
IMO we should go as far as to define namespace in the APID such that all projects have the same namespacing
No description provided.