Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated README to add did:web example #381

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Updated README to add did:web example #381

merged 3 commits into from
Oct 9, 2024

Conversation

aazam-gh
Copy link
Contributor

@aazam-gh aazam-gh commented Oct 3, 2024

Fixes #322

KendallWeihe
KendallWeihe reviewed Oct 7, 2024
View reviewed changes
crates/web5_cli/README.md
@@ -62,6 +62,91 @@ web5 vc -h
}
```

### Create a `did:jwk`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aazam-gh could you rebase onto main? (The diff viewer is showing changes from #379)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@blackgirlbytes
Copy link
Contributor

@aazam-gh let me know if you need help with the rebase. If it makes it easier, feel free to close this PR, pull the latest changes from main, make a new branch and then open a new PR

@aazam-gh
Copy link
Contributor Author

aazam-gh commented Oct 9, 2024

Is the diff still showing the changes?

KendallWeihe
KendallWeihe approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@KendallWeihe KendallWeihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @aazam-gh !

@KendallWeihe KendallWeihe merged commit 0531f5f into TBD54566975:main Oct 9, 2024
21 of 23 checks passed
@blackgirlbytes
Copy link
Contributor

Closes #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KendallWeihe KendallWeihe KendallWeihe approved these changes

@nitro-neal nitro-neal Awaiting requested review from nitro-neal nitro-neal is a code owner

@shamilovtim shamilovtim Awaiting requested review from shamilovtim shamilovtim is a code owner

@diehuxx diehuxx Awaiting requested review from diehuxx diehuxx is a code owner

@frankhinek frankhinek Awaiting requested review from frankhinek frankhinek is a code owner

@leordev leordev Awaiting requested review from leordev leordev is a code owner

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🎃 Hacktoberfest: Web5 Rust CLI Enhancements
3 participants
@aazam-gh @blackgirlbytes @KendallWeihe