-
Notifications
You must be signed in to change notification settings - Fork 1
[feat] #325 - 환경변수 통합 관리 기능 도입 #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
Summary by CodeRabbit
Walkthrough워크플로우에서 환경 변수 관리 방식을 변경하여, 여러 환경 변수를 Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Secrets Store
participant File System
GitHub Actions->>Secrets Store: Get APPLICATION_SECRET_SPRING
GitHub Actions->>File System: Write to application-secret.properties
GitHub Actions->>Gradle: Build with updated config
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.gitignore (1)
182-184: application-secret.properties 제외 규칙 추가는 적절하지만 prod 용도도 함께 고려하세요
application-secret.properties를.gitignore에 추가하여 Git 에 시크릿이 유출될 위험을 줄인 점은 👍입니다. 다만 추후 prod 환경으로 확장될 계획이라면application-secret-prod.properties와 같은 패턴도 미리 제외 규칙에 넣어 두면 실수를 예방할 수 있습니다.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/dev-CI.yml(2 hunks).gitignore(1 hunks)src/main/resources/application-dev.yml(2 hunks)
🔇 Additional comments (1)
.github/workflows/dev-CI.yml (1)
34-37: 공식 Gradle 캐시 액션 도입 👍
gradle/actions/setup-gradle@v4로 교체하며gradle-home-cache-cleanup: true설정까지 반영한 점은 캐시 불일치 문제를 줄여 빌드 성능 향상에 도움이 됩니다.
Related issue 🛠
Work Description ✏️
Trouble Shooting ⚽️
Related ScreenShot 📷
Uncompleted Tasks 😅
To Reviewers 📢