Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Gradio through HTTP - Improved Error Handling - UI fixes #213

Open
wants to merge 55 commits into
base: develop
Choose a base branch
from

Conversation

xribene
Copy link
Contributor

@xribene xribene commented Aug 20, 2024

DONE

  • Deleted anything related to python.

  • Created new GradioClient class that handles all the http requests

  • Added a new centralized space-url parser that converts all posible url formats to a SpaceInfo object.
    These formats can be

  • Refactoring and cleaning of obsolete code

  • Added objects that map the OutputLabel classes in pyharp

  • Parsing OutputLabel data from pyharp

  • added a c++ formating scheme based on JUCE guidelines using clang-format

  • Requires gradio 4.43.0

  • New and more fine-grained model status. Check ModelStatus in utils.h

  • Refactored error handling.

    • Added new ErrorType enums and an Error object. The Error object contains an ErrorType, a detailed error message (devMessage), and a corresponding user-friendly error message (userMessage).
    • A centralized function fillUserMessage that converts a devMessage to userMessage
    • A new class OpResult which is returned by many functions (i.e model->load(), model->process() etc). It lets us know if the operation was successful or not (OpResult::ok(), OpResult::fail()) and it also contains the Error object in case of failure
  • Various bug fixes and improvements

@xribene xribene self-assigned this Aug 20, 2024
@xribene xribene linked an issue Aug 20, 2024 that may be closed by this pull request
@xribene xribene linked an issue Aug 20, 2024 that may be closed by this pull request
@cwitkowitz
Copy link
Collaborator

It seems pyharp is no longer a submodule in this branch.

@xribene
Copy link
Contributor Author

xribene commented Aug 26, 2024

The pyharp folder is in the branch and included in .gitmodules. However, if you saying that because there is no "@ {commit hash}" next to the pyharp's folder name, then yes, I don't know why this is happening.

@cwitkowitz
Copy link
Collaborator

Did you change it through the git submodule interface? Or did you just move the code? You should be able to cd into the pyharp directory and call git status and other git commands.

@xribene xribene linked an issue Sep 25, 2024 that may be closed by this pull request
@xribene xribene changed the title Access Gradio through HTTPS Access Gradio through HTTP - Improved Error Handling - UI fixes Sep 26, 2024
@xribene xribene linked an issue Sep 26, 2024 that may be closed by this pull request
@xribene xribene marked this pull request as ready for review September 26, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment