Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative URL for licenseUrl in examples #11

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Use relative URL for licenseUrl in examples #11

merged 1 commit into from
Mar 11, 2024

Conversation

MattiasBuelens
Copy link
Collaborator

This makes them also work on pull request previews.

@MattiasBuelens MattiasBuelens requested a review from a team as a code owner March 11, 2024 10:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-11 12:11 UTC

@MattiasBuelens
Copy link
Collaborator Author

@jorisfluyt Now it works. 😉 https://theoplayer.github.io/documentation/pr-preview/pr-11/theoplayer/examples/basic/

@MattiasBuelens MattiasBuelens merged commit b132652 into main Mar 11, 2024
1 check passed
@MattiasBuelens MattiasBuelens deleted the fix-examples-on-pr-previews branch March 11, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisfluyt jorisfluyt jorisfluyt approved these changes

@georgechoustoulakis georgechoustoulakis Awaiting requested review from georgechoustoulakis georgechoustoulakis is a code owner automatically assigned from THEOplayer/documentation-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattiasBuelens @jorisfluyt