Conversation
|
Caution Review failedThe pull request is closed. 📋 코드 리뷰 요약Walkthrough파이어베이스 클라우드 메시징(FCM) 통합, 푸시 알림 시스템 구현, AI 도서 리뷰 기능, 그리고 만료된 방 관련 UI 상태 처리를 추가합니다. 새로운 알림 서비스 계층, 토큰 관리자, 그리고 여러 UI 및 네비게이션 업데이트를 도입합니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MainActivity
participant FCMService as MyFirebaseMessagingService
participant NotifRepo as NotificationRepository
participant MainScreen
participant NavController
User->>FCMService: 알림 수신
FCMService->>NotifRepo: onNotificationReceived()
NotifRepo->>NotifRepo: _notificationRefreshFlow 발행
FCMService->>MainActivity: 알림 표시 & Intent 전송
MainActivity->>MainActivity: onNewIntent() 호출
MainActivity->>MainActivity: handleNotificationIntent()
MainActivity->>MainActivity: notificationData 업데이트
MainScreen->>NotifRepo: checkNotification(id)
NotifRepo->>NavController: navigateFromNotification()
NavController->>User: 대상 화면으로 이동
sequenceDiagram
participant App
participant SplashViewModel
participant FcmTokenManager
participant NotificationRepository
participant Server
App->>SplashViewModel: 앱 시작
SplashViewModel->>FcmTokenManager: sendFcmToken()
FcmTokenManager->>FcmTokenManager: 저장된 토큰 확인
alt 토큰 없음
FcmTokenManager->>FcmTokenManager: Firebase에서 새 토큰 조회
end
FcmTokenManager->>NotificationRepository: registerFcmToken()
NotificationRepository->>Server: FCM 토큰 등록 API
Server-->>NotificationRepository: 성공
FcmTokenManager->>FcmTokenManager: 로컬에 토큰 저장
SplashViewModel->>App: Home 화면 네비게이션
sequenceDiagram
participant User
participant AlarmScreen
participant AlarmViewModel
participant NotificationRepository
participant MainScreen
User->>AlarmScreen: 알람 화면 진입
AlarmScreen->>AlarmViewModel: loadNotifications(reset=true)
AlarmViewModel->>NotificationRepository: getNotifications()
NotificationRepository-->>AlarmViewModel: 알림 목록
AlarmViewModel->>AlarmViewModel: uiState 업데이트
AlarmScreen->>AlarmScreen: 알림 렌더링
User->>AlarmScreen: 알림 클릭
AlarmScreen->>AlarmViewModel: checkNotification(id, onNavigate)
AlarmViewModel->>NotificationRepository: checkNotification()
NotificationRepository-->>AlarmViewModel: NotificationCheckResponse
AlarmViewModel->>MainScreen: onNavigate(response) 콜백
MainScreen->>MainScreen: navigateFromNotification()
rect rgb(200, 150, 255)
MainScreen->>MainScreen: 경로에 따라 대상 화면으로 이동
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 분 검토 시 특별히 주의할 사항:
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (91)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
주요 변경사항
새로운 기능
개선사항