Skip to content

fix(roundtable): render confirmation dialog inside fullscreen container#305

Merged
wyuc merged 1 commit intomainfrom
fix/fullscreen-dialog
Mar 26, 2026
Merged

fix(roundtable): render confirmation dialog inside fullscreen container#305
wyuc merged 1 commit intomainfrom
fix/fullscreen-dialog

Conversation

@cosarah
Copy link
Copy Markdown
Collaborator

@cosarah cosarah commented Mar 26, 2026

Summary

  • Fixed scene-switch confirmation dialog being invisible during fullscreen presentation mode
  • The AlertDialog was portaled to document.body by default, which is outside the fullscreen element and therefore hidden
  • Added optional container prop to AlertDialogContent and pass stageRef.current when in fullscreen mode

Closes #304

Test plan

  • Enter a roundtable discussion
  • Switch to fullscreen presentation mode
  • Click "Next Page" while discussion is active
  • Confirmation dialog appears correctly inside the fullscreen view
  • Clicking confirm advances to the next page
  • Normal (non-fullscreen) mode still works as before

🤖 Generated with Claude Code

…er (#304)

The scene-switch confirmation AlertDialog was portaled to document.body,
making it invisible during fullscreen presentation mode. Pass the
fullscreen container (stageRef) as the portal target when presenting.

Closes #304

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@cosarah cosarah requested a review from wyuc March 26, 2026 13:55
Copy link
Copy Markdown
Contributor

@wyuc wyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Approved

@wyuc wyuc merged commit 38f36a6 into main Mar 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Fullscreen mode blocks 'next page' confirmation dialog during active discussion

2 participants