Skip to content

fix(roundtable): use inline style for breathing bar background color (#306)#307

Merged
cosarah merged 1 commit intomainfrom
fix/breathing-bar-tailwind4
Mar 27, 2026
Merged

fix(roundtable): use inline style for breathing bar background color (#306)#307
cosarah merged 1 commit intomainfrom
fix/breathing-bar-tailwind4

Conversation

@wyuc
Copy link
Copy Markdown
Contributor

@wyuc wyuc commented Mar 27, 2026

Summary

Fix invisible breathing bars in presentation speech bubbles by switching from dynamic Tailwind classes to inline styles.

Related Issues

Fixes #306

Changes

  • Replace dynamic cn('w-1 rounded-full', barsColor) with static className="w-1 rounded-full" + style={{ backgroundColor: barsColor }}
  • Change barsColor from Tailwind class names ('bg-blue-500' / 'bg-purple-500') to hex values ('#3b82f6' / '#a855f7')

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Verification

Steps to reproduce / test

  1. Open a classroom with TTS enabled
  2. Enter presentation/immersive mode via fullscreen button
  3. Play a lecture — observe the bottom-right corner of speech bubbles
  4. Before: bars are invisible. After: colored bars animate correctly.

What you personally verified

  • Tested on Chrome and Safari in dev mode
  • Verified bars show correct colors (blue for agent, purple for others)
  • Verified hover state still shows pause icon
  • Verified breathing animation timing unchanged

Evidence

  • CI passes (pnpm check && pnpm lint && npx tsc --noEmit)
  • Manually tested locally
  • Screenshots / recordings attached (if UI changes) — visual bug, fix is self-evident from the code

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have added/updated documentation as needed
  • My changes do not introduce new warnings

Tailwind 4 purges dynamically constructed class names passed through
cn(). The breathing bars in presentation speech bubbles were invisible
because `bg-blue-500` / `bg-purple-500` were tree-shaken from the CSS.

Switch to inline `backgroundColor` style which is not subject to purging.
Copy link
Copy Markdown
Collaborator

@cosarah cosarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
verified

@cosarah cosarah merged commit 817d098 into main Mar 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(roundtable): breathing bars invisible in presentation speech bubbles

2 participants