fix(settings): allow model-level test connection without client-side API key#309
Open
fix(settings): allow model-level test connection without client-side API key#309
Conversation
…API key and fix i18n keys Remove the client-side apiKey guard in model edit dialog so test connection delegates to the server (matching provider-level behavior). Also replace non-existent common.save/common.cancel i18n keys with settings.saveModel/ settings.cancelEdit in image and video model dialogs. Closes #308 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ilable Match provider-level behavior: disable the test connection button in the model edit dialog when requiresApiKey && !apiKey && !isServerConfigured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!apiKeyguard inmodel-edit-dialog.tsxhandleTestModelso that model-level "Test Connection" delegates API key resolution to the server, matching provider-level behavior. Previously, if no client-side API key was entered, the test would immediately fail with "API Key is required" even when a valid server-side key was configured.common.save,common.cancel) in image and video model dialogs — replaced with existingsettings.saveModelandsettings.cancelEditkeys.Closes #308
Test plan
🤖 Generated with Claude Code