[codex] Fix MiniMax TTS fallback and HTML extraction#528
Draft
dragon-hh wants to merge 1 commit intoTHU-MAIC:mainfrom
Draft
[codex] Fix MiniMax TTS fallback and HTML extraction#528dragon-hh wants to merge 1 commit intoTHU-MAIC:mainfrom
dragon-hh wants to merge 1 commit intoTHU-MAIC:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two provider-integration issues found while running OpenMAIC with a server-configured MiniMax setup:
/api/generate/ttsRoot cause
The TTS API previously treated any request-level
ttsBaseUrlas a fully client-supplied provider configuration. When the UI sent the server-synced MiniMaxserverBaseUrl, the route skipped the server API key fallback and failed withAPI key required for TTS provider: minimax-tts.Interactive widget generation also required a complete
</html>document or a closed Markdown code fence. Some model responses start with valid HTML inside a ```html block but may omit the final</html>or closing fence, causing scene-content generation to fail even though usable HTML was present.Changes
extractHtmlso valid started HTML can be extracted even when the model response is truncated.Validation
pnpm test tests/generation/scene-generator-language-directive.test.ts tests/audio/minimax-tts-models.test.ts tests/server/provider-config.test.ts tests/store/settings-server-sync.test.tsResult: 4 test files passed, 82 tests passed.