-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix link of Big Techday talk & Java aktuell #1810
Conversation
docs.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/TNG/JGiven/blob/master/README.md links to https://jgiven.org/docs/, but I did not see how this was reachable from https://jgiven.org/.
Do we want to maintain this page? Couldn't the README simply link to https://jgiven.org/?
c699ec2
to
464ee2f
Compare
57cd903
to
bc14595
Compare
It seems that the |
README.md
Outdated
@@ -1,76 +1 @@ | |||
[![Build Status](https://img.shields.io/github/actions/workflow/status/tng/jgiven/jgiven_branch_and_pr_build.yml?branch=master)](https://github.com/TNG/JGiven/actions/workflows/jgiven_branch_and_pr_build.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are those fancy badges out?
I kinda like them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had essentially removed the entire README
on the gh-pages
branch as long as it was out of sync with the master
branch, to avoid redunant (and outdate) information. If you prefer to keep those branches synchronized, that commit should be dropped, of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire point of rebasing gh-pages is that I want to have changes on the main branch be in gh-pages as well.
Consequently, the readme should not be touched in the gh-pages branch...
(but apparently it has. Thatwould be somethign for me to fix)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've dropped the commit touching README.md
(and rebased to the current version of the gh-actions
branch 😉).
464ee2f
to
07f44e4
Compare
Signed-off-by: Manfred Hanke <[email protected]>
Signed-off-by: Manfred Hanke <[email protected]>
bc14595
to
0257fd6
Compare
This PR fixes some links on https://jgiven.org/ (i.e. branch
gh-pages
).The old link to the video of the Big Techday talk is not available anymore.