Bugfix/issue 755 #778
Merged
Bugfix/issue 755 #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: l-1sqared <[email protected]>
Signed-off-by: l-1sqared <[email protected]>
Signed-off-by: l-1sqared <[email protected]> Issue-755: set up testcases Signed-off-by: l-1sqared <[email protected]>
The source of the incorrect timings is that the StepInterceptor and the ScenarioModelBuilder have different concepts about what a step is. Consequently, in the eyes of the scenario builder, the stepMethodFinished is called way more often than it should be. This is the source of incorrect timings in the presence of nested steps, intro and filler words. The current solution tries to track the and accomodate for the difference in understandings when it comes to timings. The limitation on timing is part of what makes this implementation so awful. Signed-off-by: l-1sqared <[email protected]>
l-1squared
commented
Dec 8, 2021
| } | ||
| } | ||
|
|
||
| if (!hasNestedSteps && !parentSteps.isEmpty()) { | ||
| currentStep = parentSteps.peek(); | ||
| } | ||
|
|
||
| if (discrepancyOnLayer.peek() > 0) { |
There was a problem hiding this comment.
the condition should be placed in the decrement discrepancy method
Signed-off-by: Christian Oertel <[email protected]>
fudler
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.