Show timer also for spectator #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophNiehoff
force-pushed
the
show_timer_in_spectator_mode
branch
from
6dd4bdf
to
1a9ed3b
Compare
ghost91-
requested changes
Jun 29, 2023
| @@ -98,6 +98,8 @@ class Board extends React.Component { | |||
| this.props.ctx.activePlayers[this.props.playerID] === 'threats' | |||
| ? true | |||
| : false; | |||
| // If this.props.playerID is unset, then we are in spectator mode and check whether the first player is in threat stage. | |||
There was a problem hiding this comment.
maybe we could introduce some descriptive functions instead of the comment. Something like:
const isSpectator = () => !!this.props.playerID;
const isFirstPlayerInThreatStage = () => this.props.ctx.activePlayers?.[0] === 'threats';
const shouldShowTimer = isInThreatStage || (isSpectator() && isFirstPlayerInThreatStage());
Signed-off-by: Christoph Niehoff <[email protected]>
ChristophNiehoff
force-pushed
the
show_timer_in_spectator_mode
branch
from
1a9ed3b
to
dd49d10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the spectator should be able to see the timer.