Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy enhanced mode #45

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Privacy enhanced mode #45

merged 6 commits into from
Jul 6, 2023

Conversation

ChristophNiehoff
Copy link
Contributor

Changed "Provide model via a different channel (e.g. video stream)" to a "privacy enhanced" mode

  • Is is not mandatory to upload a model/image
  • You can only upload a link to a model/image (e.g. inside a restricted wiki)
  • Threats are supposed to be documented elsewhere. You only have to provide a reference id for the threat (e.g. the ticket number of a restricted Jira)

@ChristophNiehoff ChristophNiehoff force-pushed the privacy_enhanced_mode branch 2 times, most recently from 4286e24 to def50e9 Compare June 9, 2023 14:01
Copy link
Contributor

@ghost91- ghost91- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks very good, just a few small comments 👍

src/game/gameState.ts Outdated Show resolved Hide resolved
src/client/components/threatmodal/threatmodal.jsx Outdated Show resolved Hide resolved
src/client/styles/create.css Outdated Show resolved Hide resolved
Signed-off-by: Christoph Niehoff <[email protected]>
Signed-off-by: Christoph Niehoff <[email protected]>
Signed-off-by: Christoph Niehoff <[email protected]>
Signed-off-by: Christoph Niehoff <[email protected]>
@ChristophNiehoff ChristophNiehoff merged commit d2e22fc into master Jul 6, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants