Skip to content

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented Aug 16, 2025

Pull Request

Purpose

Added Streaming Service ATV (This is NOT ATVP)

  • ATVP is Apple Originals.
  • ATV is channels, i.e., non-Apple Originals.

It seems to use the same encoding engine as ATVP, but has DNR applied.

  • DNR => (dynamic noise reduction) rather visible, losing details in faces, etc

We still need to decide on which scoring to use.

Approach

Added Streaming Service ATV (This is NOT ATVP)

Open Questions and Pre-Merge TODOs

  • Set ATV scoring for Sonarr

Requirements

Summary by Sourcery

New Features:

  • Add custom format definitions for the new ATV streaming service in Radarr and Sonarr

Copy link
Contributor

sourcery-ai bot commented Aug 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR introduces a new “ATV” custom format for non-Apple Originals streaming channels by adding JSON definitions for both Radarr and Sonarr that reuse the ATVP encoding settings with dynamic noise reduction applied and highlights a pending scoring decision for Sonarr.

File-Level Changes

Change Details Files
Add ATV custom format definitions
  • Create Radarr custom format JSON
  • Create Sonarr custom format JSON
  • Apply DNR parameters matching ATVP encoding
docs/json/radarr/cf/atv.json
docs/json/sonarr/cf/atv.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Aug 16, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:d4c344f8e0f4cb19a831f985e3feb77a06fa33c3
Status: ✅  Deploy successful!
Preview URL:https://db4ab2e4.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2465.trash-guides-6xu.pages.dev

Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:0c9772900d5c0f78ab7ecab7d06369f2607c8b40
Status: ✅  Deploy successful!
Preview URL:https://f80474a9.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2465.trash-guides-6xu.pages.dev

@TRaSH- TRaSH- linked an issue Aug 16, 2025 that may be closed by this pull request
@beschoenen
Copy link

I've added ATV locally, because I was missing it, too.
I did however also add Apple TV to the regex.

\b(atv|Apple TV)\b

@TRaSH-
Copy link
Contributor Author

TRaSH- commented Oct 3, 2025

I've added ATV locally, because I was missing it, too. I did however also add Apple TV to the regex.

\b(atv|Apple TV)\b

Sorry for the late reply, I would suggest using \b(atv|Apple[ .-_]TV)\b

@TRaSH-
Copy link
Contributor Author

TRaSH- commented Oct 3, 2025

This PR is included in #2508

@TRaSH- TRaSH- closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] (Starr): Add Streaming Service ATV (This is **NOT** ATVP)
2 participants