Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input_handlers.py #56

Open
wants to merge 1 commit into
base: 2020/part-1
Choose a base branch
from

Conversation

lingawakad
Copy link

In v12.3, SDL2 changed Key constants to enums e.g. tcod.event.K_UP should be replaced with tcod.event.KeySym.UP

Seems like it's not a problem yet, but errors popping up can be frightening:

FutureWarning: Key constants have been replaced with enums. 'tcod.event.K_UP' should be replaced with 'tcod.event.KeySym.UP'

I changed all the branches, but that seems like a lot of PRs - pls lmk the best way to do that, i'm still a git noob.

@HexDecimal
Copy link
Collaborator

You propagate changes by merging them into the subsequent part branches and then into the master branch. This is tedious but it at least means you'd only have to edit the branches where key constants are actually added.

I can probably work with what you have now and merge it.

@HexDecimal
Copy link
Collaborator

The main issue is that the roguelike tutorials website isn't being updated at the moment. So I'm not sure how to push the changes there.

@lingawakad
Copy link
Author

lingawakad commented Aug 16, 2023

The main issue is that the roguelike tutorials website isn't being updated at the moment. So I'm not sure how to push the changes there.

Yeah, but at least it's in the source i guess.

I can push the changes in part-6 as well, it looks like that should cover most of it. or all 13 parts.

@HexDecimal
Copy link
Collaborator

The changes have to be propagated across subsequent parts which all have to be merged. You only need this one PR to show that your changes are ready.

I'm going to wait for TStand90/roguelike-tutorials-website#40 to be closed before I work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants