Skip to content

Fix Bug: imagePullSecrets not working for autograding #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fix Bug: imagePullSecrets not working for autograding #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/grader-service/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ kubeAutogradeExecutor:
image: ghcr.io/tu-wien-datalab/grader-service-labextension
tag: latest
imagePullPolicy: "Always"
imagePullSecrets: {}
imagePullSecrets: []
labels: {}
namespace: null
extraVolumes: ""
Expand Down
5 changes: 3 additions & 2 deletions grader_service/autograding/kube/kube_grader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,10 @@ class KubeAutogradeExecutor(LocalAutogradeExecutor):
help="The image pull policy for the pod. Defaults to 'Always'.").tag(config=True)

# Dictionary to store image pull secrets, helpful when pulling from private registries
image_pull_secrets = Dict(default_value=None,
image_pull_secrets = List(default_value=[],
help="""Autograding pod image pull secrets dictionary (str, str).
Used for pulling images from private registries. Defaults to None.""",
key_trait=Unicode(),
key_trait=Unicode(),
value_trait=Unicode(),
allow_none=True).tag(config=True)

Expand Down Expand Up @@ -319,6 +319,7 @@ def start_pod(self) -> GraderPod:
env=env,
image=self.get_image(),
image_pull_policy=self.image_pull_policy,
image_pull_secrets=self.image_pull_secrets,
working_dir="/",
volumes=volumes,
volume_mounts=volume_mounts,
Expand Down
Loading