Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker file for developer #43

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Add docker file for developer #43

merged 1 commit into from
Sep 14, 2023

Conversation

LianxinGao
Copy link
Contributor

as title

@LianxinGao
Copy link
Contributor Author

LianxinGao commented Sep 12, 2023

#7 Btw. our repo is private, so the docker file cannot run successfully

@yezhengmao1 yezhengmao1 self-requested a review September 12, 2023 08:07
@yezhengmao1
Copy link
Collaborator

Do you test it when the clone is successful?

Copy link
Contributor

@merlintang merlintang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you give the bash command to run this build model? like fine tune or inference.

@LianxinGao
Copy link
Contributor Author

Do you test it when the clone is successful?

successfully tested on other public repo

@merlintang merlintang changed the title add docker file Add docker file for developer Sep 12, 2023
@merlintang
Copy link
Contributor

merlintang commented Sep 12, 2023 via email

@LianxinGao
Copy link
Contributor Author

LianxinGao commented Sep 12, 2023

Because of the dockerfile cannot mount the host's dir, so we cannot mount base_model and cannot finetune when docker build. We can only prepare a docker that users can run finetune as soon as they start the docker rather than having to install dependencies.

So, this pr is needed or not? @merlintang

@merlintang merlintang merged commit 28d2af3 into main Sep 14, 2023
4 checks passed
@merlintang merlintang deleted the docker_dev branch September 14, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants