Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped UTM support #369

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Dropped UTM support #369

merged 1 commit into from
Jan 29, 2023

Conversation

CommanderStorm
Copy link
Member

Proposed Changes (include Screenshots if possible)

  • This PR drops the support for UTM being delivered to the client
  • Main reason is, that I doubt anybody would ever need this feature (most tools support lat-lon)

How to test this PR

  1. Check if utm is really removed from API responses

How has this been tested?

  • Genereated a few responses, for which utm did not show up

Checklist:

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

Note, that this will need an entry in #130

@CommanderStorm CommanderStorm requested a review from octycs January 28, 2023 01:42
@CommanderStorm CommanderStorm self-assigned this Jan 28, 2023
octycs
octycs approved these changes Jan 29, 2023
View reviewed changes
Copy link
Contributor

@octycs octycs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all fine. Yes, UTM is probably not used, and anyone can convert themselves. I also don't know why the original roomfinder used it.

@octycs octycs merged commit 6cf2705 into main Jan 29, 2023
@octycs octycs deleted the no_utm branch January 29, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octycs octycs octycs approved these changes

Assignees

@CommanderStorm CommanderStorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommanderStorm @octycs