Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1413 vis feedback #1428

Merged
merged 21 commits into from
Jan 10, 2025
Merged

1413 vis feedback #1428

merged 21 commits into from
Jan 10, 2025

Conversation

KemalKrKX
Copy link
Contributor

Motivation and Context

#1413

Description

The page refreshes after lecture deletion, giving visual feedback of changes

Steps for Testing

Prerequisites:

  • 1 Lecture
  • 1 Admin
  1. Log in
  2. Create and delete a lecture
  3. Page refreshes automatically, lecture does not stay on page

@KemalKrKX KemalKrKX requested a review from a team January 6, 2025 15:43
Copy link

github-actions bot commented Jan 6, 2025

Your Testserver will be ready at https://1428.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Member

@carlobortolan carlobortolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but I think you might have implemented it for the wrong delete button (see review comments)

dao/courses.go Outdated Show resolved Hide resolved
web/template/home.gohtml Outdated Show resolved Hide resolved
web/ts/data-store/admin-lecture-list.ts Outdated Show resolved Hide resolved
@KemalKrKX KemalKrKX self-assigned this Jan 7, 2025
Copy link
Member

@carlobortolan carlobortolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KemalKrKX KemalKrKX merged commit 70d099a into dev Jan 10, 2025
8 checks passed
@KemalKrKX KemalKrKX deleted the 1413-VisFeedback branch January 10, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting lectures doesn't give immediate visual feedback to the user
3 participants