-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing, anyone? #171
base: main
Are you sure you want to change the base?
Editing, anyone? #171
Conversation
I'm glad you've taken an interest in this because I'm not really maintaining it anymore. I took a look at your PR, and while I'm not spending a lot of time really testing it, I did have some quick comments:
Again, while I definitely appreciate the work, I'd encourage you to head over to the Visidata project at some point and spend some more time with that project as it's actively maintained. Thanks! |
I didn't expect to get a review on this PR - I thought it might be out of the scope of the project, but it would be great if it was incorporated!
I've rebound things ad-hoc to suit my use-case, so I'm not sure it'll be to everyone's taste. Nonetheless I'll update the README and it could be figured out in more detail later.
Aha, I was only testing it against the file I was editing. I'll try to fix these as soon as possible.
Good idea - will do!
Yes, I am aware of (and have used) visidata but specifically chose |
I couldn't seem to find the problem with |
Wide characters were taking two keypresses to move over. Maybe that's ok...I really don't have any experience there! |
Me neither... I guess I'll leave it as-is for now, unless/until someone can clarify how it should correctly behave. |
078cb71
to
bffbf47
Compare
I've used |
README updated too. I think this PR is mostly ready. |
I pushed a new version of py_curses_editor to pypi with your PRs. What do you think about making py_curses_editor an optional dependency and just prompt the user to install if those functions are accessed? That way tabview's use as a simple and quick viewer can still be used without any dependencies. Edit: also make sure you rebase on main. I noticed one PR (adding pbcopy support) that wasn't included in your changes. |
I've used it throughout - including for the Help, so it's pretty much integral. I think it should either be merged into this repo or become a necessary dependency. |
Fixes #17. Implements basic editing, undo/redo, saving, and searching headers.