-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(core): Add a Generic/General OAuth client #4325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Wei Zhang <[email protected]>
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
Maybe, name it as OIDC |
I appreciate the feedback, however, I am going to wait for the Tabby maintainers to leave some feedback before I make any further changes. |
This reverts commit 6aec931.
…auth' into feature/3rd-party-oauth
…auth' into feature/3rd-party-oauth
…bmission for other SSO providers
2240338
to
59c9608
Compare
This reverts commit b90beee.
This PR contains changes in order to add a generalised OAuth client.
Please note that I am aware this feature is behind a pay-wall and I absolutely respect the Tabby team's decision to keep this behind a pay-wall. I want to emphasise this is a POC and my intent here was to quickly learn Rust and to give back to Tabby.
The benefit of having a generalised OAuth client is that end users can integrate with 3rd party identity providers (such as Auth0, Okta, Authentik, etc.). This is achieved by using OpenID Connect Discovery which contains the endpoints required to:
On the backend, I am introducing a new migration to add a
config_url
to theoauth_credential
table. This column is avarchar(256)
and should accomodate most identity provider's Connect Discovery endpoints,I also changed the frontend here and here screenshots and explanations as to how the UX looks like:
Existing OAuth Integrations will not display the new Config URL text field

New Radio Button to show the General OAuth Configs:

View the show page for a created General OAuth Configs:

SSO Sign In Page:

Please also note this branch contains changes from #4323 and I am hoping to merge the upstream PR before merging this one in.