Skip to content

Conversation

liangfung
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 51.28205% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.10%. Comparing base (56661ba) to head (e6dbcf5).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ee/tabby-schema/src/schema/setting.rs 0.00% 29 Missing ⚠️
ee/tabby-schema/src/schema/mod.rs 0.00% 16 Missing ⚠️
ee/tabby-schema/src/schema/license.rs 0.00% 11 Missing ⚠️
ee/tabby-webserver/src/service/license.rs 66.66% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (51.28%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4334      +/-   ##
==========================================
- Coverage   55.12%   55.10%   -0.02%     
==========================================
  Files         235      235              
  Lines       26878    26994     +116     
==========================================
+ Hits        14816    14875      +59     
- Misses      12062    12119      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wsxiaoys wsxiaoys changed the title WIP: support white label WIP: support custom logo Aug 6, 2025
@liangfung liangfung force-pushed the feat/support-white-label branch from 4239535 to b757ff9 Compare August 6, 2025 09:38
@liangfung liangfung force-pushed the feat/support-white-label branch from ce83acd to 6fa77a0 Compare August 6, 2025 14:27
@liangfung liangfung changed the title WIP: support custom logo feat(server, ui): support custom logo Aug 7, 2025
@liangfung liangfung requested review from zwpaper and wsxiaoys August 7, 2025 11:44
@liangfung liangfung marked this pull request as ready for review August 7, 2025 11:44
Copy link
Member

@zwpaper zwpaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM

@@ -422,6 +423,12 @@ impl Query {
ctx.locator.setting().read_security_setting().await
}

async fn branding_setting(ctx: &Context) -> Result<BrandingSetting> {
let license = ctx.locator.license().read().await?;
license.ensure_available_features("custom-logo")?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use an enum to represent all the possible features? (although there is only one currently)

@liangfung liangfung merged commit f9ac621 into main Aug 7, 2025
6 of 8 checks passed
@liangfung liangfung deleted the feat/support-white-label branch August 7, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants