-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(server, ui): support custom logo #4334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (51.28%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4334 +/- ##
==========================================
- Coverage 55.12% 55.10% -0.02%
==========================================
Files 235 235
Lines 26878 26994 +116
==========================================
+ Hits 14816 14875 +59
- Misses 12062 12119 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4239535
to
b757ff9
Compare
ce83acd
to
6fa77a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise, LGTM
ee/tabby-schema/src/schema/mod.rs
Outdated
@@ -422,6 +423,12 @@ impl Query { | |||
ctx.locator.setting().read_security_setting().await | |||
} | |||
|
|||
async fn branding_setting(ctx: &Context) -> Result<BrandingSetting> { | |||
let license = ctx.locator.license().read().await?; | |||
license.ensure_available_features("custom-logo")?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use an enum to represent all the possible features? (although there is only one currently)
No description provided.