Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable menu items and menubar class refactor #713

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mashed5894
Copy link
Contributor

Fix for #692. Disables a list of menu options until a library is loaded and disables them again when the library is closed.
Also moved the menu_bar into a separate class. Still need to rewrite some of the tests.

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: Refactor Code that needs to be restructured or cleaned up Type: UI/UX User interface and/or user experience labels Jan 19, 2025
@mashed5894
Copy link
Contributor Author

waiting on 9.5 because of the significant refactoring

@xarvex
Copy link
Member

xarvex commented Mar 12, 2025

Hi! What's the current status here post-9.5?

@mashed5894
Copy link
Contributor Author

i havent touched this since i opened it, but i heard in the discord that there is some refactoring happening! would definitely be interested in getting in on the action, ive noticed several similar refactorings that could be done throughout the project.

@CyanVoxel
Copy link
Member

i havent touched this since i opened it, but i heard in the discord that there is some refactoring happening! would definitely be interested in getting in on the action, ive noticed several similar refactorings that could be done throughout the project.

The refactor mentioned in the discord was in reference to #844 which was spun up and merged last week. That was a restructuring of the project layout to better align with a standard python src-layout structure, which corrected several issues we were having in the process.

Still, a refactor of ts_qt.py - most notably the separation of the now menu bar code, is still needed. The current driving force behind this is the need to refactor the Qt driver in a way that is easier to integrate with the tests. The general size of the file is a reason too, but the tests are the pressing issue. Because of this and my familiarity with the file I feel it would be best if I took on the task of splitting up the Qt driver myself.

@Computerdores
Copy link
Collaborator

i havent touched this since i opened it, but i heard in the discord that there is some refactoring happening! would definitely be interested in getting in on the action, ive noticed several similar refactorings that could be done throughout the project.

The refactor mentioned in the discord was in reference to #844 which was spun up and merged last week. That was a restructuring of the project layout to better align with a standard python src-layout structure, which corrected several issues we were having in the process.

Still, a refactor of ts_qt.py - most notably the separation of the now menu bar code, is still needed. The current driving force behind this is the need to refactor the Qt driver in a way that is easier to integrate with the tests. The general size of the file is a reason too, but the tests are the pressing issue. Because of this and my familiarity with the file I feel it would be best if I took on the task of splitting up the Qt driver myself.

There is also a lot of code duplication in the way the menu bar is built, so there is potential for improvements at that specific point as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as intended Type: Refactor Code that needs to be restructured or cleaned up Type: UI/UX User interface and/or user experience
Projects
Status: 🚧 In progress
Development

Successfully merging this pull request may close these issues.

4 participants