feat(ui): show stems for extension-less files #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Enhancement
|
Functions fine on windows but on shutdown it throws this error 2025-04-02 01:02:26 [error ] [Preview Panel] Error updating selection error=AttributeError("'NoneType' object has no attribute 'suffix'")
Traceback (most recent call last):
File "C:\dev\TagStudio\src\tagstudio\qt\widgets\preview_panel.py", line 136, in update_widgets
self.file_attrs.update_stats()
File "C:\dev\TagStudio\src\tagstudio\qt\widgets\preview\file_attributes.py", line 135, in update_stats
ext = filepath.suffix.lower()
^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'suffix' |
Computerdores
approved these changes
Apr 4, 2025
| self.switch_preview("image") | ||
|
|
||
| image: Image.Image | None = None | ||
|
|
||
| if MediaCategories.is_ext_in_category( | ||
| ext, MediaCategories.IMAGE_RAW_TYPES, mime_fallback=True | ||
| filepath.suffix.lower(), MediaCategories.IMAGE_RAW_TYPES, mime_fallback=True |
There was a problem hiding this comment.
Shouldn't this use ext instead of recomputing the same value?
| self.update_thumb(timestamp, image=image), | ||
| self.update_size(timestamp, size=size), | ||
| self.set_filename_text(filename), | ||
| self.set_extension(ext), # type: ignore | ||
| self.set_extension(filename), # type: ignore |
There was a problem hiding this comment.
Why is this ignore comment necessary? Removing this doesn't trigger any warning for me locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR displays file stems in place of extensions for extension-less filenames inside item thumbnails and the preview panel. The prior behavior was to show no label if there was no extension, which made browsing these extension-less files difficult.
Note: Yes, this example shows several filetypes that should normally be excluded from TagStudio libraries. That is not related to this PR.
Tasks Completed